snuyanzin commented on code in PR #26547:
URL: https://github.com/apache/flink/pull/26547#discussion_r2201719497
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/aggfunctions/LiteralAggFunction.java:
##########
@@ -40,8 +41,11 @@ public abstract class LiteralAggFunction extends
DeclarativeAggregateFunction {
private final UnresolvedReferenceExpression literalAgg =
unresolvedRef("literalAgg");
private static final Expression[] EMPTY_EXPRS = new Expression[0];
private static final DataType[] EMPTY_DATATYPES = new DataType[0];
+ protected final RexLiteral rexLiteral;
Review Comment:
removed together with turning off literalAgg
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/AggFunctionFactory.scala:
##########
@@ -285,22 +285,24 @@ class AggFunctionFactory(
}
}
- private def createLiteralAggFunction(relDataType: RelDataType):
UserDefinedFunction = {
+ private def createLiteralAggFunction(
+ relDataType: RelDataType,
+ rexNode: RexNode): UserDefinedFunction = {
relDataType.getSqlTypeName match {
case SqlTypeName.BOOLEAN =>
- BooleanLiteralAggFunction.INSTANCE
+ new BooleanLiteralAggFunction(rexNode.asInstanceOf[RexLiteral])
Review Comment:
removed together with turning off literalAgg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
