twalthr commented on code in PR #26547:
URL: https://github.com/apache/flink/pull/26547#discussion_r2219250227
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/AggFunctionFactory.scala:
##########
@@ -31,7 +31,10 @@ import
org.apache.flink.table.runtime.functions.aggregate.PercentileAggFunction.
import org.apache.flink.table.types.logical._
import org.apache.flink.table.types.logical.LogicalTypeRoot._
+import org.apache.calcite.rel.`type`.RelDataType
import org.apache.calcite.rel.core.AggregateCall
+import org.apache.calcite.rex.{RexLiteral, RexNode}
Review Comment:
undo
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/agg/batch/HashAggCodeGenHelper.scala:
##########
@@ -203,7 +203,7 @@ object HashAggCodeGenHelper {
val initAggCallBufferExprs = aggInfos
.map(_.function.asInstanceOf[DeclarativeAggregateFunction])
- .flatMap(_.initialValuesExpressions)
+ .flatMap(e => e.initialValuesExpressions)
Review Comment:
undo
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/agg/batch/AggCodeGenHelper.scala:
##########
@@ -84,7 +86,7 @@ object AggCodeGenHelper {
.map(index => Array(inputType.getTypeAt(index)))
val aggTypes = aggInfos
- .map(_.externalAccTypes.map(fromDataTypeToLogicalType))
+ .map({ a => a.externalAccTypes.map(fromDataTypeToLogicalType) })
Review Comment:
undo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
