snuyanzin commented on code in PR #27845:
URL: https://github.com/apache/flink/pull/27845#discussion_r3008532979
##########
flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/service/materializedtable/MaterializedTableManagerTest.java:
##########
@@ -136,66 +136,66 @@ static Stream<TestSpec> testData() {
// The interval of freshness match the partition specified by
the 'date-formatter'.
TestSpec.create()
.schedulerTime("2024-01-01 00:00:00")
- .freshness(IntervalFreshness.ofDay("1"))
+ .freshness(IntervalFreshness.ofDay(1))
Review Comment:
hm, there is no `START_MODE` tests yet since it is just a prep PR to extract
`Interval`, so not sure what tests for `START_MODE` you are referring to
>String parameters may cause runtime parsing errors; recommend unifying to
integer parameters.
I didn't get that, can you clarify what you mean here?
From PR you can see that it is introduced int arg methods
string args are deprecated, however we can not simply remove them since it
is public api
>Repeated test logic can be extracted into factory methods or generated
loops to reduce maintenance.
are you referring to some specific code lines?
here it was only change input arg, for refactoring (if needed) it would make
sense to have a separate PR since it will require more changes in tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
