snuyanzin commented on code in PR #27845:
URL: https://github.com/apache/flink/pull/27845#discussion_r3008536584
##########
flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/api/internal/ShowCreateUtilTest.java:
##########
@@ -313,7 +313,7 @@ private static Collection<Arguments>
argsForShowCreateMaterializedTable() {
null,
List.of(),
null,
- IntervalFreshness.ofMinute("1"),
+ IntervalFreshness.ofMinute(1),
Review Comment:
What do you mean by this?
can you give an example?
Also I'm not a fan of lots of comments especially in case of non public code
or tests, because people might forget to update them updating/refactoring the
actual code... (just my opinion)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
