monologuist commented on issue #252:
URL: https://github.com/apache/flink-agents/issues/252#issuecomment-4160387112

   Hi @GreatEugenius , thanks for the hint about the log4j approach!
   
   After reviewing the codebase, I found that Flink itself uses a similar 
pattern in TaskManager startup code — reading `System.getProperty("log.file")` 
and calling `.getParent()` to obtain the log directory. 
   
   I plan to follow the same convention in `FileEventLogger`: resolve the 
default base directory by reading the `log.file` system property (injected by 
Flink's startup scripts), and fall back to `java.io.tmpdir/flink-agents` for 
local/test environments where the property is not set.
   
   Does this approach look good to you? Happy to proceed with a PR if so.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to