Sxnan commented on PR #602:
URL: https://github.com/apache/flink-agents/pull/602#issuecomment-4174318976

   ### Code review
   
   Found 2 issues:
   
   1. Test directory has a typo: `python/flink_agents/plan/tests/actoins/` 
should be `python/flink_agents/plan/tests/actions/`. The misspelling "actoins" 
is inconsistent with the source directory `plan/actions/` and the rest of the 
codebase.
   
   
https://github.com/GreatEugenius/flink-agents/blob/380f17eccd83e819c9c2e5466a6651dd6bcf5986/python/flink_agents/plan/tests/actoins/__init__.py#L1-L1
   
   2. Documentation type mismatch: `configuration.md` lists 
`retry-wait-interval-ms` as type `int`, but `AgentExecutionOptions.java` 
defines it as `ConfigOption<Long>`. Other entries are consistent (e.g., 
`max-retries` is `int` / `Integer`), so this should be `long`.
   
   
https://github.com/GreatEugenius/flink-agents/blob/380f17eccd83e819c9c2e5466a6651dd6bcf5986/docs/content/docs/operations/configuration.md#L132-L134
   
   🤖 Generated with [Claude Code](https://claude.ai/code)
   
   <sub>- If this code review was useful, please react with 👍. Otherwise, react 
with 👎.</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to