Sxnan commented on code in PR #602:
URL: https://github.com/apache/flink-agents/pull/602#discussion_r3025686621
##########
python/flink_agents/runtime/local_runner.py:
##########
@@ -170,14 +170,16 @@ def long_term_memory(self) -> BaseLongTermMemory:
def agent_metric_group(self) -> MetricGroup:
# TODO: Support metric mechanism for local agent execution.
err_msg = "Metric mechanism is not supported for local agent execution
yet."
- raise NotImplementedError(err_msg)
+ logger.warning(err_msg)
Review Comment:
We should also update the return type of the method to `MetricGroup | None`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
