locchipinti commented on code in PR #4357:
URL: https://github.com/apache/flink-cdc/pull/4357#discussion_r3037342317


##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/source/MySqlDataSourceOptions.java:
##########
@@ -93,6 +93,21 @@ public class MySqlDataSourceOptions {
                     .withDescription(
                             "The chunk size (number of rows) of table 
snapshot, captured tables are split into multiple chunks when read the snapshot 
of table.");
 
+    public static final ConfigOption<String> SCAN_SNAPSHOT_HOSTNAME =
+            ConfigOptions.key("scan.snapshot.hostname")
+                    .stringType()
+                    .noDefaultValue()
+                    .withDescription(
+                            "Optional IP address or hostname of a MySQL read 
replica to use for snapshot and metadata"
+                                    + "queries (table discovery, chunk 
splitting). When set, all snapshot data reads and metadata"
+                                    + "operations are routed to this instance, 
reducing load on the primary writer."
+                                    + "Binlog position tracking and changelog 
streaming always use the primary writer instance."
+                                    + "WARNING: At-least-once semantics only. 
When this option is set, exactly-once"
+                                    + "guarantees cannot be maintained because 
the binlog positions recorded during snapshot"
+                                    + "scanning originate from the primary 
writer while the data is read from the replica, and"
+                                    + "storage replication lag (even in the 
millisecond range, as with Aurora/RDS) means the"
+                                    + "two positions may not be perfectly 
consistent.");

Review Comment:
   Fixed. Added trailing spaces to all concatenated string segments so the 
description renders correctly as prose.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to