locchipinti commented on code in PR #4357:
URL: https://github.com/apache/flink-cdc/pull/4357#discussion_r3037354677
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/config/MySqlSourceConfigFactory.java:
##########
@@ -84,6 +85,16 @@ public MySqlSourceConfigFactory hostname(String hostname) {
return this;
}
+ /**
+ * Optional hostname of a MySQL read replica to use for snapshot queries.
When set, snapshot
+ * data will be read from this replica instead of the primary writer
instance, reducing the load
+ * on the writer. The binlog position will still be obtained from the
primary writer instance.
+ */
+ public MySqlSourceConfigFactory snapshotHostname(String snapshotHostname) {
+ this.snapshotHostname = snapshotHostname;
Review Comment:
Fixed. The setter in MySqlSourceConfigFactory now normalizes an empty string
to null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
