Daishuyuan commented on PR #4320: URL: https://github.com/apache/flink-cdc/pull/4320#issuecomment-4204175498
Thanks for the review. I addressed the comments in the latest commits. Updated: - added null `namespace` fallback handling in the metadata accessor - registered `scan.incremental.snapshot.chunk.key-column` - improved `tables` validation and related error messages - relaxed database name validation for SQL Server - fixed chunk distribution factor error messages to use `CHUNK_KEY_*` - fixed bracket escaping in identifier quoting - corrected `REAL` / `FLOAT` type mapping - cleaned up a few test and wording issues raised in review - added regression tests for the above cases I also updated the SQL Server error 313 handling in the source connector. Instead of retrying with the same stale LSN, it now fails fast with a clear message that the CDC range is no longer available and suggests re-snapshotting or advancing to the minimum available LSN. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
