twalthr commented on code in PR #27920:
URL: https://github.com/apache/flink/pull/27920#discussion_r3072125262


##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/functions/SqlLikeUtils.java:
##########
@@ -97,7 +97,7 @@ public static String sqlToRegexLike(String sqlPattern, 
CharSequence escapeStr) {
             }
             escapeChar = escapeStr.charAt(0);
         } else {
-            escapeChar = '\\';

Review Comment:
   @Au-Miner Could you double check all changes made in 
https://github.com/apache/flink/commit/ae4eb7dc3ae399659e52da39f7ac74242aaca3b5#diff-b2e1701d6c7cae434d495536a397325850d12a59023d320cbad9389aa7d17b2d
 Don't we also need to restore the other lines SqlLikeUtils. If a character 
(doesn't need to be the escape charater) is a special regex character, we need 
to escape it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to