davidradl commented on code in PR #27920:
URL: https://github.com/apache/flink/pull/27920#discussion_r3073246492
##########
docs/data/sql_functions.yml:
##########
@@ -50,9 +50,9 @@ comparison:
description: By default (or with the ASYMMETRIC keyword), returns TRUE if
value1 is less than value2 or greater than value3. With the SYMMETRIC keyword,
returns TRUE if value1 is not inclusively between value2 and value3. When
either value2 or value3 is NULL, returns TRUE or UNKNOWN. E.g., 12 NOT BETWEEN
15 AND 12 returns TRUE; 12 NOT BETWEEN SYMMETRIC 15 AND 12 returns FALSE; 12
NOT BETWEEN NULL AND 15 returns UNKNOWN; 12 NOT BETWEEN 15 AND NULL returns
TRUE; 12 NOT BETWEEN SYMMETRIC 12 AND NULL returns UNKNOWN.
- sql: string1 LIKE string2 [ ESCAPE char ]
table: string1.like(string2[, char])
- description: Returns TRUE if string1 matches pattern string2; returns
UNKNOWN if string1 or string2 is NULL. An escape character consisting of a
single char can be defined if necessary, `\` by default.
+ description: Returns TRUE if string1 matches pattern string2; returns
UNKNOWN if string1 or string2 is NULL. An escape character consisting of a
single char can be defined using the ESCAPE clause if necessary. There is no
default escape character.
- sql: string1 NOT LIKE string2 [ ESCAPE char ]
- description: Returns TRUE if string1 does not match pattern string2;
returns UNKNOWN if string1 or string2 is NULL. An escape character consisting
of a single char can be defined if necessary, `\` by default.
+ description: Returns TRUE if string1 does not match pattern string2;
returns UNKNOWN if string1 or string2 is NULL. An escape character consisting
of a single char can be defined using the ESCAPE clause if necessary. There is
no default escape character.
Review Comment:
@twalthr thanks for the background. I notice that
[Spark](https://spark.apache.org/docs/latest/sql-ref-syntax-qry-select-like.html#:~:text=The%20default%20escape%20character%20is%20%5C%20.&text=Specifies%20a%20regular%20expression%20search,the%20RLIKE%20or%20REGEXP%20clause.)
does have a default for escape of `/`. Looking at the history I can go along
with removing the default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
