featzhang commented on PR #27897:
URL: https://github.com/apache/flink/pull/27897#issuecomment-4257096600
Thanks @RocMarshal for pointing that out! I've now gone through the entire
`RawFormatLineDelimiterTest.java` file and applied the same fixes consistently:
- Replaced all `"UTF-8"` string literals with `StandardCharsets.UTF_8` (in
`.getBytes()` calls) and `StandardCharsets.UTF_8.name()` (in constructor
parameters)
- Replaced all `.getString(0).toString()).isEqualTo("...") ` assertions with
`.getString(0)).hasToString("...")`
- Added the missing `import java.nio.charset.StandardCharsets;`
The fix covers all test methods:
`testDeserializeWithoutDelimiter_singleRow`,
`testDeserializeWithNewlineDelimiter_multipleRows`,
`testDeserializeWithCustomMultiCharDelimiter`,
`testDeserializeWithNullMessage_noOutput`, `testDeserializeWithGbkCharset`, all
serialization tests, `testDeserializeTrailingDelimiter_noExtraRow`, and
`testRoundTrip_serializeThenDeserialize`.
@RocMarshal PTAL, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
