featzhang commented on PR #27897: URL: https://github.com/apache/flink/pull/27897#issuecomment-4266261253
> @featzhang , @RocMarshal any reason config option was added without FLIP/ML discussion? asking since if we look at main FLIP page (section `What is considered a "major change" that needs a FLIP?`) https://cwiki.apache.org/confluence/display/FLINK/Flink+Improvement+Proposals > > > > > All of the following are public interfaces that people build around: > > ``` > DataStream, DataSet, SQL and Table API, including classes related to that, such as StreamExecutionEnvironment > > Classes marked with the @Public annotation > > On-disk binary formats, such as checkpoints/savepoints > > User-facing scripts/command-line tools, i.e. bin/flink, Yarn scripts, Kubernetes scripts > > Configuration settings > > Exposed monitoring information > ``` Hi @snuyanzin, thanks for raising this concern — and apologies for not initiating the discussion beforehand. The `raw.line-delimiter` option is: - **Optional with no default** — existing behavior is entirely unchanged when the option is absent. - **Additive-only** — it adds a new capability without modifying any existing code paths. - **Format-scoped** — it is isolated to the `raw` format connector and does not touch any `@Public` API or SQL/Table API surface. My understanding (which may be wrong) was that minor additive options within a format connector fall below the FLIP threshold, similar to how many other format options (e.g., `csv.field-delimiter`, `json.ignore-parse-errors`) were introduced without a FLIP. That said, I fully respect the community's position. If the consensus is that this option should have gone through FLIP/ML discussion, I'm happy to: 1. Open a FLIP retroactively to formally document the design rationale, or 2. Revert the change if the community feels it was premature. What would you recommend, @snuyanzin and @RocMarshal? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
