davidradl commented on code in PR #27899:
URL: https://github.com/apache/flink/pull/27899#discussion_r3129180764
##########
flink-runtime/src/main/java/org/apache/flink/runtime/instance/HardwareDescription.java:
##########
@@ -150,7 +150,7 @@ public String toString() {
//
--------------------------------------------------------------------------------------------
public static HardwareDescription extractFromSystem(long managedMemory) {
- final int numberOfCPUCores = Hardware.getNumberCPUCores();
+ final double numberOfCPUCores = Hardware.getNumberCPUCoresAsDouble();
Review Comment:
Please can you add tests for this change I am curious what happens if we
have a third of a CPU - i.e. irrational
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
