davidradl commented on code in PR #27899:
URL: https://github.com/apache/flink/pull/27899#discussion_r3129188691
##########
flink-runtime/src/main/java/org/apache/flink/runtime/instance/HardwareDescription.java:
##########
@@ -141,7 +141,7 @@ public int hashCode() {
@Override
public String toString() {
return String.format(
- "cores=%d, physMem=%d, heap=%d, managed=%d",
+ "cores=%s, physMem=%d, heap=%d, managed=%d",
Review Comment:
my AI says :
High Priority Issues
🟠HIGH - Division by Zero Risk: Period validation in cgroup v1 code needs
verification to ensure it happens before division operation
Medium Priority Issues
Missing unit tests for new cgroup detection methods
No handling for cgroup v2 hybrid mode scenarios
Missing documentation distinguishing when to use getNumberCPUCores() vs
getNumberCPUCoresAsDouble()
Thread pool multiplier (4x) may still over-provision for fractional CPUs
Low Priority Issues
Magic string "max" should be constant
Redundant file existence checks
Format specifier inconsistency in toString()
Path traversal validation missing
Test fixtures need fractional value testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
