joeyutong commented on code in PR #628:
URL: https://github.com/apache/flink-agents/pull/628#discussion_r3144672601
##########
docs/content/docs/operations/configuration.md:
##########
@@ -140,14 +140,35 @@ Here is the list of all built-in core configuration
options.
### Action State Store
+#### Common
+
+| Key | Default | Type | Description
|
+|------------------------------|------------------|---------|------------------------------------------------------------------------------------------|
+| `actionStateStoreBackend` | (none) | String | The backend for
action state store. Supported values: `"kafka"`, `"fluss"`. |
+
#### Kafka-based Action State Store
Here are the configuration options for Kafka-based Action State Store.
| Key | Default | Type |
Description |
|-------------------------------------|--------------------------|---------|-----------------------------------------------------------------------------|
-| `actionStateStoreBackend` | (none) | String |
The config parameter specifies the backend for action state store. |
| `kafkaBootstrapServers` | "localhost:9092" | String |
The config parameter specifies the Kafka bootstrap server. |
| `kafkaActionStateTopic` | (none) | String |
The config parameter specifies the Kafka topic for action state. |
| `kafkaActionStateTopicNumPartitions`| 64 | Integer |
The config parameter specifies the number of partitions for the Kafka action
state topic. |
| `kafkaActionStateTopicReplicationFactor` | 1 | Integer |
The config parameter specifies the replication factor for the Kafka action
state topic. |
+
+#### Fluss-based Action State Store
+
+Here are the configuration options for Fluss-based Action State Store. Fluss
provides O(1) KV point lookup for action state, eliminating the need for
in-memory state rebuilding during recovery.
+
Review Comment:
This sentence still sounds like the earlier PK/KV-table design. The current
implementation uses a log table plus in-memory cache and `rebuildState()`, so
the claim about O(1) KV point lookup and no in-memory rebuilding is misleading.
Could we keep this as just "Here are the configuration options for Fluss-based
Action State Store."?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
