joeyutong commented on code in PR #628:
URL: https://github.com/apache/flink-agents/pull/628#discussion_r3144776072
##########
runtime/pom.xml:
##########
@@ -116,6 +116,58 @@ under the License.
<artifactId>kafka-clients</artifactId>
<version>${kafka.version}</version>
</dependency>
+ <!-- fluss client -->
+ <dependency>
+ <groupId>org.apache.fluss</groupId>
+ <artifactId>fluss-client</artifactId>
+ <version>${fluss.version}</version>
+ </dependency>
+ <!-- fluss test infrastructure -->
+ <dependency>
+ <groupId>org.apache.fluss</groupId>
+ <artifactId>fluss-server</artifactId>
+ <version>${fluss.version}</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.fluss</groupId>
+ <artifactId>fluss-server</artifactId>
+ <version>${fluss.version}</version>
+ <type>test-jar</type>
+ <scope>test</scope>
+ </dependency>
Review Comment:
Could we double-check whether all Fluss test dependencies are required here?
`fluss-client` is needed by the runtime code, and the embedded cluster test
seems to need `fluss-server`, `fluss-server` test-jar, `fluss-test-utils`, and
`curator-test`. But I don't see direct usage of the `fluss-common` and
`fluss-rpc` test-jars from this test. If they are not needed for
`FlussClusterExtension`, it would be better to keep the runtime module
dependency surface smaller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
