spuru9 commented on code in PR #27774:
URL: https://github.com/apache/flink/pull/27774#discussion_r3173367336
##########
flink-runtime-web/web-dashboard/angular.json:
##########
@@ -114,7 +114,8 @@
"cli": {
"schematicCollections": [
"@angular-eslint/schematics"
- ]
+ ],
+ "analytics": "1079c058-8210-47b6-a042-622faf66601e"
Review Comment:
nit: revert this change.
##########
flink-runtime-web/web-dashboard/src/app/pages/job/topn-metric/job-topn-metric.component.ts:
##########
@@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { ChangeDetectionStrategy, ChangeDetectorRef, Component, OnDestroy,
OnInit } from '@angular/core';
+import { Subject } from 'rxjs';
+import { takeUntil } from 'rxjs/operators';
+
+import { TopNMetricsComponent } from
'@flink-runtime-web/components/topn-metrics/topn-metrics.component';
+import { BackpressureOperatorInfo, CpuConsumerInfo, GcTaskInfo } from
'@flink-runtime-web/interfaces';
+import { JobLocalService } from
'@flink-runtime-web/pages/job/job-local.service';
+
+@Component({
+ selector: 'flink-job-topn-metric',
+ templateUrl: './job-topn-metric.component.html',
+ changeDetection: ChangeDetectionStrategy.OnPush,
+ standalone: true,
+ imports: [TopNMetricsComponent]
+})
+export class JobTopnMetricComponent implements OnInit, OnDestroy {
Review Comment:
Naming inconsistency
- Shared widget: TopNMetricsComponent (components/topn-metrics/)
- Per-job page: JobTopnMetricComponent (lowercase n, singular metric, dir
topn-metric/)
- Tab title: 'TopN Metric' (singular)
Would be nice to make it consistent.
##########
flink-runtime-web/web-dashboard/package-lock.json:
##########
@@ -824,18 +824,6 @@
}
}
},
- "node_modules/@angular/build/node_modules/@types/node": {
Review Comment:
Net −1267 lines with no package.json change. Revert unless intentional.
##########
flink-runtime-web/web-dashboard/src/app/pages/job-manager/logs/job-manager-logs.component.ts:
##########
@@ -20,26 +20,24 @@ import { ChangeDetectorRef, Component, OnInit,
ChangeDetectionStrategy, OnDestro
import { ConfigService, JobManagerService } from '@flink-runtime-web/services';
import { EditorOptions } from 'ng-zorro-antd/code-editor';
import { flinkEditorOptions } from
'@flink-runtime-web/components/editor/editor-config';
-import {of, Subject} from 'rxjs';
-import {catchError, takeUntil} from 'rxjs/operators';
+import { of, Subject } from 'rxjs';
Review Comment:
Though these changes are correct, but create unintended changes uncreated to
this PR. Have created a seperate JIRA
[FLINK-39587](https://issues.apache.org/jira/browse/FLINK-39587) for resolving
this. Would help reduce the noise in the future. WDYT?
Would be nice to do outside the scope of this PR.
##########
flink-runtime-web/web-dashboard/src/app/pages/overview/overview.component.html:
##########
@@ -17,9 +17,14 @@
-->
<flink-overview-statistic
[statisticData$]="statisticData$"></flink-overview-statistic>
+<flink-topn-metrics
+ [topCpuConsumers]="topCpuConsumers"
+ [topBackpressureOperators]="topBackpressureOperators"
+ [topGcIntensiveTasks]="topGcIntensiveTasks"
+></flink-topn-metrics>
<flink-application-list
[applicationData$]="applicationData$"
- [title]="'Running Application List'"
+ [title]="'Running Application List with topCpuConsumers'"
Review Comment:
nit: debug change? Wont be a nice UX for customers Ig.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
