featzhang commented on PR #27774: URL: https://github.com/apache/flink/pull/27774#issuecomment-4362609509
Follow-up: added `TopNMetricsHandlerTest` (commit 00c17089f1) to address **M1** from my self-review. Eight focused unit tests cover: - CPU dimension — TaskManager-scoped, sorted by `Status.JVM.CPU.Load`, with `subtaskId=-1` / `operatorName="TaskManager"` contract - Backpressure dimension — subtask-scoped, ratio clamped to `[0, 1]`, correctly sorted desc - GC dimension — summed across all reported `Status.JVM.GarbageCollector.<name>.Time` entries - topN cut-off at the default of 5 - Graceful fall-through on an empty `MetricStore` and on jobs that have not reported any metrics yet Local run: `Tests run: 8, Failures: 0, Errors: 0, Skipped: 0` (~0.36s). `spotless:check` clean. The remaining M/N items from the self-review (making `topN` configurable, collapsing duplicate `getTopXxx` helpers, unrelated file-format churn, etc.) are still tracked on that comment and I'll batch them once reviewers weigh in on the approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
