spuru9 opened a new pull request, #28086:
URL: https://github.com/apache/flink/pull/28086
## What is the purpose of the change
`.eslintignore` has a bare `logs` pattern that uses gitignore
semantics — it matches a directory of that name at any depth. It was
meant for a top-level log-output directory but also captures
`src/app/pages/{job-manager,task-manager}/logs/`, the source dirs
holding the dashboard's log pages. Files under those paths were
silently skipped by `lint-staged`, CI, and IDE eslint, so style drift
accumulated and eventually leaked into a feature PR (#27774) as
unrelated reformat noise.
## Brief change log
- Anchor the pattern at the project root: `logs` -> `/logs`.
- Run `eslint --fix` on both `*-logs.component.ts` files (prettier
whitespace/quotes/brackets, `import/order`, import deduplication).
- Add `: void` return types to `ngOnInit` and `reload` in both
components (`@typescript-eslint/explicit-function-return-type` is
not auto-fixable).
## Verifying this change
cd flink-runtime-web/web-dashboard
rm -f .eslintcache
npm run lint # exits 0; both files are now included by eslint
## Does this pull request potentially affect one of the following parts
- Dependencies: no
- Public API: no
- Serializers: no
- Runtime per-record code paths: no
- Deployment/recovery (JobManager, Checkpointing, K8s/Yarn, ZooKeeper): no
- S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
## Was the change made with AI assistance?
- [x] Claude Code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
