featzhang commented on code in PR #28086:
URL: https://github.com/apache/flink/pull/28086#discussion_r3177018072


##########
flink-runtime-web/web-dashboard/.eslintignore:
##########
@@ -5,7 +5,7 @@ tsc-out
 dist

Review Comment:
   Same bare-pattern footgun applies to `dist` here and `tsc-out` on the line 
above — they will also match any nested directory of that name. No source dirs 
collide today, but anchoring them (`/dist`, `/tsc-out`) in the same commit 
would close the loophole for good and keep the three top-level artifact dirs 
consistent. Non-blocking.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to