desruisseaux commented on PR #508: URL: https://github.com/apache/maven-jar-plugin/pull/508#issuecomment-5313564546
> in this new implementation, is the `MANIFEST.MF` content still generated first by our usual tooling, then only added to the jar and tidied up by `jar` tool? Yes. The plugin is still using `MavenArchiver` and `MavenArchiveConfiguration` from the `org.apache.maven.shared.archiver` package. The plugin uses the archiver for getting an initial `META-INF.MF` file, then gives the path to that file to the `jar` tool using the `--manifest` option. Preparing a `MANIFEST.MF` is the only functionality of `MavenArchiver` that the new implementation is still using. We could bring that functionality in the plugin, which would remove the dependency to Archiver. But I keep that for a separated discussion later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
