ascheman commented on PR #508: URL: https://github.com/apache/maven-jar-plugin/pull/508#issuecomment-5327301051
> @hboutemy: since reproducible build is supported only partially on Java 17 and 18, we were wondering if it should be a hard build failure if reproducible build is requested on Java 17 or 18. Currently, it is only a warning. If we make it a hard failure, since the `project.build.outputTimestamp` property has a default value in the super POM of all Maven 4 projects, the JAR plugin would fail by default for everyone using Java 17 or 18. A workaround is to opt-out reproducible build in the `pom.xml`: > > ``` > <properties> > <project.build.outputTimestamp/> <!-- For compatibility with Java 17 and 18. --> > </properties>` > ``` There are even more workarounds, i.e., fall back to the 3.x plugin or use a newer JDK (still setting source/target to 17), cf. https://github.com/apache/maven-jar-plugin/commit/0490a3f6e5a9dabf00a0731e5ba51cb267b3e37c (final documentation outstanding). > At first, we though that silently producing a non-fully reproducible build on Java 17/18 would be damageable. On a second though, I now think that having all Maven 4 projects failing by default on Java 17/18 is worst. Do you have any opinion on this matter? In my opinion, we should rather break the build than _only issue a warning_. However, that would hit many people hard when switching to M4/m-jar-p 4.x while still using JDK 17/18. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
