slachiewicz opened a new pull request, #934: URL: https://github.com/apache/maven-wagon/pull/934
`HugeFileDownloadTest` exists to catch a byte count held in an `int`, which overflows above `Integer.MAX_VALUE`. The constant was set to twice that, so every run transferred ~4 GiB rather than the ~2 GiB the check actually needs — double the cost for the same coverage. It is now `Integer.MAX_VALUE + 1024L`, still past the boundary, with the reasoning written on the constant so it does not get rounded back up. The file itself is sparse, so this changes the transfer, not the disk footprint. Measured on the class alone, deleting `target/hugefile.txt` first so the file is recreated each time: | | time | cases | failures | |---|---|---|---| | before | 29.98s | 2 | 0 | | after | 5.47s | 2 | 0 | | after, second run | 5.50s | 2 | 0 | Worth being straight about the scale: that is a real saving but a small share of a Verify run, which has been taking 22–25 minutes on this repo for a while. The larger costs are `TckTest` at 56.6s and the Jetty/TLS classes — `HttpsWagonTest` 31.7s, `HttpWagonPreemptiveTest` 29.6s, `HttpsWagonPreemptiveTest` 30.1s, `HttpWagonTest` 29.5s — and those are inherent to what they test. *This change was created with AI assistance.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
