slachiewicz opened a new pull request, #935:
URL: https://github.com/apache/maven-wagon/pull/935

   Backport of #934. This branch's copy was identical to master's before that 
change, so it applies
   verbatim.
   
   `HugeFileDownloadTest` exists to catch a byte count held in an `int`, which 
overflows above
   `Integer.MAX_VALUE`. The constant was set to twice that, so every run 
transferred ~4 GiB rather than
   the ~2 GiB the check needs. It is now `Integer.MAX_VALUE + 1024L`, still 
past the boundary, with the
   reasoning written on the constant. The file is sparse, so this changes 
transfer time, not disk use.
   
   Measured on this branch, on the class alone, deleting `target/hugefile.txt` 
first so it is recreated:
   
   | | time | cases | failures |
   |---|---|---|---|
   | before | 12.70s | 2 | 0 |
   | after | 5.08s | 2 | 0 |
   
   The before figure is lower than the 29.98s measured on master for the same 
starting code — same
   machine, so treat these as one machine's numbers rather than a benchmark; 
the direction and the
   reason for it are what matter.
   
   *This change was created with AI assistance.*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to