seregamorph commented on PR #508:
URL: https://github.com/apache/maven-jar-plugin/pull/508#issuecomment-5343943459
1. @ascheman thanks, I've rechecked your PR and I'd like to confirm - it
fixes the problem with directories, now the spring application is starting 👍
2. the good news is that JARs are reproducible, at least on my
machine/os/jvm version, and it's binary reproducible.
There was a comment regarding "semantically reproducible" instead of "binary
reproducible" - that's not acceptable, at least because it breaks Docker
layered file system optimization. It can be lenient for the timestamp of files,
but if the JAR file content is different (like different order or timestamp),
it will not work. At scale that's a significant factor.
3. what I've noticed is that MANIFEST.MF are now having two entries
```
Manifest-Version: 1.0
Created-By: 25.0.3 (Amazon.com Inc.)
```
while the original MANIFEST had only `Manifest-Version: 1.0` @desruisseaux ,
please recheck this regression.
The configuration is
```xml
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<configuration>
<archive>
<addMavenDescriptor>false</addMavenDescriptor>
<manifest>
<addDefaultEntries>false</addDefaultEntries>
</manifest>
</archive>
</configuration>
</plugin>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
