hboutemy commented on PR #508: URL: https://github.com/apache/maven-jar-plugin/pull/508#issuecomment-5347824551
I just tested building a few simple projects with misc JDKs and this PR: ``` mvn -V -e -Dversion.maven-jar-plugin=4.0.0-beta-2-SNAPSHOT -DskipTests clean package artifact:3.6.1:describe-build-output ; unzip -p target/*-SNAPSHOT.jar META-INF/MANIFEST.MF ``` first, I can see the the `META-INF/MANIFEST.MF` file remains as usual: great from my test, with JDK 19+, result is locally reproducible: I always get the same output on the same laptop I did not yet try to compare builds on different machines, I'll check later with JDK 17 and 18, not reproducible: no problem with order of files, but with timestamp and also a timestamp is injected in pom.properties To me, avoid the issue with pom.properties should be easy and postprocessing jar file to set timestamp should not be hard: like moditect for example https://github.com/moditect/moditect/blob/41784cb65f9a564012212ba94307ad98455d789d/core/src/main/java/org/moditect/commands/AddModuleInfo.java#L115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
