[
https://issues.apache.org/jira/browse/IMPALA-5384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475389#comment-16475389
]
ASF subversion and git services commented on IMPALA-5384:
---------------------------------------------------------
Commit da329442a598c29c97b9f43964c1b2af263c8391 in impala's branch
refs/heads/2.x from [~dhecht]
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=da32944 ]
IMPALA-5384, part 2: Simplify Coordinator locking and clarify state
The is the final change to clarify and break up the Coordinator's lock.
The state machine for the coordinator is made explicit, distinguishing
between executing state and multiple terminal states. Logic to
transition into a terminal state is centralized in one location and
executes exactly once for each coordinator object.
Derived from a patch for IMPALA_5384 by Marcel Kornacker.
Testing:
- exhaustive functional tests
- stress test on minicluster with memory overcommitment. Verified from
the logs that this exercises all these paths:
- successful queries
- client requested cancellation
- error from exec FInstances RPC
- error reported asynchronously via report status RPC
- eos before backend execution completed
Change-Id: I1abdfd02163f9356c59d470fe1c64ebe012a9e8e
Reviewed-on: http://gerrit.cloudera.org:8080/10158
Reviewed-by: Dan Hecht <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-on: http://gerrit.cloudera.org:8080/10389
> Simplify coordinator locking protocol
> -------------------------------------
>
> Key: IMPALA-5384
> URL: https://issues.apache.org/jira/browse/IMPALA-5384
> Project: IMPALA
> Issue Type: Improvement
> Affects Versions: Impala 2.9.0
> Reporter: Marcel Kornacker
> Assignee: Dan Hecht
> Priority: Major
>
> The coordinator has a central lock (lock_) which is used very liberally to
> synchronize state changes that don't need to be synchronized, creating a
> concurrency bottleneck.
> Also, the coordinator contains a number of data structures related to INSERT
> finalization that don't need to be part of and synchronized with the rest of
> the coordinator state.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
