[
https://issues.apache.org/jira/browse/IMPALA-5384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475393#comment-16475393
]
ASF subversion and git services commented on IMPALA-5384:
---------------------------------------------------------
Commit 4ce9dbb475ef52812691d0cddae6df75ab496369 in impala's branch
refs/heads/master from [~dhecht]
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=4ce9dbb ]
IMPALA-7024: Convert Coordinator::wait_lock_ to SpinLock
For consistency with the other locks in this class, use
SpinLock rather than boost::mutex. We expect SpinLock to
work okay for locks that block since it is adaptive.
This came up in the code review for IMPALA-5384, but I
wanted to make this change separately, just in case of
unforseen side-effects.
Change-Id: I48b2e7f819b1180f82811abf5701c8d07e6505e3
Reviewed-on: http://gerrit.cloudera.org:8080/10392
Reviewed-by: Tim Armstrong <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Simplify coordinator locking protocol
> -------------------------------------
>
> Key: IMPALA-5384
> URL: https://issues.apache.org/jira/browse/IMPALA-5384
> Project: IMPALA
> Issue Type: Improvement
> Affects Versions: Impala 2.9.0
> Reporter: Marcel Kornacker
> Assignee: Dan Hecht
> Priority: Major
>
> The coordinator has a central lock (lock_) which is used very liberally to
> synchronize state changes that don't need to be synchronized, creating a
> concurrency bottleneck.
> Also, the coordinator contains a number of data structures related to INSERT
> finalization that don't need to be part of and synchronized with the rest of
> the coordinator state.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
