[
https://issues.apache.org/jira/browse/IMPALA-7212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554600#comment-16554600
]
ASF subversion and git services commented on IMPALA-7212:
---------------------------------------------------------
Commit 8d7f63865405c50981647ae3198bd4d39b465bf8 in impala's branch
refs/heads/master from Michael Ho
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=8d7f638 ]
IMPALA-7212: Removes --use_krpc flag and remove old DataStream services
This change removes the flag --use_krpc which allows users
to fall back to using Thrift based implementation of DataStream
services. This flag was originally added during development of
IMPALA-2567. It has served its purpose.
As we port more ImpalaInternalServices to use KRPC, it's becoming
increasingly burdensome to maintain parallel implementation of the
RPC handlers. Therefore, going forward, KRPC is always enabled.
This change removes the Thrift based implemenation of DataStreamServices
and also simplifies some of the tests which were skipped when KRPC
is disabled.
Testing done: core debug build.
Change-Id: Icfed200751508478a3d728a917448f2dabfc67c3
Reviewed-on: http://gerrit.cloudera.org:8080/10835
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Deprecate --use_krpc flag
> -------------------------
>
> Key: IMPALA-7212
> URL: https://issues.apache.org/jira/browse/IMPALA-7212
> Project: IMPALA
> Issue Type: Sub-task
> Components: Distributed Exec
> Affects Versions: Impala 3.0
> Reporter: Michael Ho
> Assignee: Michael Ho
> Priority: Major
>
> {{--use_krpc}} was introduced in 2.9.0 during development of adopting KRPC
> for DataStream services (IMPALA-2567). It was initially hidden and set to
> false as it wasn't fully implemented yet. Since 2.12.0 and 3.0, this flag is
> set to true by default. Going forward, we will port more services to KRPC and
> it's become very burdensome to keep both Thrift RPC and KRPC implementation
> for converted RPCs. The best route forward is to drop this flag for 3.0+
> releases.
> cc'ing [~dhecht], [~sailesh], [~lv]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
