[
https://issues.apache.org/jira/browse/IMPALA-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554601#comment-16554601
]
ASF subversion and git services commented on IMPALA-2567:
---------------------------------------------------------
Commit 8d7f63865405c50981647ae3198bd4d39b465bf8 in impala's branch
refs/heads/master from Michael Ho
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=8d7f638 ]
IMPALA-7212: Removes --use_krpc flag and remove old DataStream services
This change removes the flag --use_krpc which allows users
to fall back to using Thrift based implementation of DataStream
services. This flag was originally added during development of
IMPALA-2567. It has served its purpose.
As we port more ImpalaInternalServices to use KRPC, it's becoming
increasingly burdensome to maintain parallel implementation of the
RPC handlers. Therefore, going forward, KRPC is always enabled.
This change removes the Thrift based implemenation of DataStreamServices
and also simplifies some of the tests which were skipped when KRPC
is disabled.
Testing done: core debug build.
Change-Id: Icfed200751508478a3d728a917448f2dabfc67c3
Reviewed-on: http://gerrit.cloudera.org:8080/10835
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> KRPC milestone 1
> ----------------
>
> Key: IMPALA-2567
> URL: https://issues.apache.org/jira/browse/IMPALA-2567
> Project: IMPALA
> Issue Type: Bug
> Components: Distributed Exec
> Affects Versions: Impala 2.2.4
> Reporter: Henry Robinson
> Assignee: Michael Ho
> Priority: Critical
> Labels: scalability
> Fix For: Impala 3.0, Impala 2.12.0
>
>
> Impala relies on Thrift 0.9.X for its RPC implementation. This is a venerable
> release and is showing its age. Problems include:
> * Low-quality SASL support (that we implemented ourselves)
> * Lack of high-quality nonblocking server ({{TNonBlockingServer}} is ok, but
> doesn't work with SASL, making it a non-starter for us. It is also very hard
> to provide support for sessions with {{TNonBlockingServer}}).
> * Lack of 0-copy native bytes type, meaning that large data structures are
> inefficient to send
> * Lack of support for async. server implementation, so expensive RPCs can
> consume threads that could have been used by cheap ones.
> Both [Kudu|https://github.com/cloudera/kudu/tree/master/src/kudu/rpc] and
> [fbthrift|https://github.com/facebook/fbthrift/blob/master/thrift/doc/Cpp2.md]
> have RPC implementations that address some or all of these shortcomings. We
> should evaluate both and commit to moving our RPC stack to one or the other.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
