[
https://issues.apache.org/jira/browse/IMPALA-7825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16708954#comment-16708954
]
Sahil Takiar commented on IMPALA-7825:
--------------------------------------
Attached a patch for what I have done so far for the Thrift 11 upgrade. Some
highlights:
* The main issue is that THRIFT-2221 migrated the Thrift C++ code from
{{boost::shared_ptr}} to {{std::shared_ptr}} this caused a bunch of compilation
issues in Impala that took a while to fix
** This caused a few issue with {{boost::enable_shared_from_this}} vs
{{std::enable_shared_from_this}} as well
* As stated in my previous comment, upgrading to Thrift 11 will require an
impyla release that is compiled against Thrift 11 - I have done this is a
private Github fork here:
[https://github.com/sahilTakiar/impyla/tree/thrift-0.11-upgrade]
* The changes to native-toolchain for the Thrift 11 upgrade can be found here:
[https://github.com/sahilTakiar/native-toolchain/tree/thrift-0.11-upgrade]
> Upgrade Thrift version to 0.11.0
> --------------------------------
>
> Key: IMPALA-7825
> URL: https://issues.apache.org/jira/browse/IMPALA-7825
> Project: IMPALA
> Issue Type: Improvement
> Components: Infrastructure
> Reporter: Lars Volker
> Assignee: Sahil Takiar
> Priority: Major
> Labels: performance
> Attachments: thrift-0.11-upgrade.patch
>
>
> Thrift has added performance improvements to its Python deserialization code.
> We should upgrade to 0.11.0 to make use of those.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
