[
https://issues.apache.org/jira/browse/IMPALA-7993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767569#comment-16767569
]
ASF subversion and git services commented on IMPALA-7993:
---------------------------------------------------------
Commit b2f305c0029ecc96015bd655fff47bebee286ace in impala's branch
refs/for/master from Tim Armstrong
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=b2f305c ]
Remove some noisier clang-tidy rules
These rules generate a lot of warnings and generally aren't
considered best practices in our codebase.
This may help a bit with IMPALA-7993.
Change-Id: I12d61dccff0f9772165c10238ae178208a100706
> Fix build and scripts to be more useful to developers
> -----------------------------------------------------
>
> Key: IMPALA-7993
> URL: https://issues.apache.org/jira/browse/IMPALA-7993
> Project: IMPALA
> Issue Type: Improvement
> Components: Infrastructure
> Affects Versions: Impala 3.1.0
> Reporter: Paul Rogers
> Priority: Major
>
> Got a build failure on a Gerrit patch. The tidy log.txt file is 300 MB in
> size with 3.4 million lines. It contains 87,535 warnings identified by a
> "~~~" squiggle, 122 occurrences of the word "failure", 6947 occurrences of
> "fail", and 35,503 occurrences of the word "error." The bottom of the file
> states "7988 warnings generated." Indeed, there are 1077 occurrences of the
> line "warnings generated" in the build.
> It is not realistic for a human to plow through this stuff looking for the
> one obscure pattern that indicates and actual problem.
> This build is unusually large and verbose for an open source project.
> Some improvements:
> * Separate out normal "narration" (echoing of shell commands) from actual
> error output.
> * Fix the code to eliminate warnings, or turn off the warnings.
> * Turn off the extra checks which we just ignore.
> * Create a script that will grep through the file looking for the actual
> failures, ignoring the "expected" errors and failures, identifying the real
> ones.
> It also appears that the scripts build Javadoc (can't tell for what.) Impala
> is famous for its highly unorthodox use of Javadoc comments; the generate
> Javadoc will be gibberish. Either fix the comments to be Java-doc compliant,
> or stop building Javadoc.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
