[ 
https://issues.apache.org/jira/browse/IMPALA-7993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767851#comment-16767851
 ] 

Jim Apple commented on IMPALA-7993:
-----------------------------------

It might be possible to fix this just in the clang-tidy-ub1604 Jenkins job. 
That job runs buildall.sh with the {{-tidy}} flag before running 
run_clang_tidy.sh.

The goal was to not waste user time trying to figure out the clang-tidy 
*warning* when there was a compilation error, because the clang-tidy output was 
way too dang big. Joe fixed that in 
https://gitbox.apache.org/repos/asf?p=impala.git;h=27c788f826820791fcdd972b55afd970d6643c1a,
 so I'll remove the canary call in the Jenkins job and see how it goes.

Tim was that {{refs/for/master}} thing an accidental push to Apache, rather 
than gerrit?

> Fix build and scripts to be more useful to developers
> -----------------------------------------------------
>
>                 Key: IMPALA-7993
>                 URL: https://issues.apache.org/jira/browse/IMPALA-7993
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Infrastructure
>    Affects Versions: Impala 3.1.0
>            Reporter: Paul Rogers
>            Priority: Major
>
> Got a build failure on a Gerrit patch. The tidy log.txt file is 300 MB in 
> size with 3.4 million lines. It contains 87,535 warnings identified by a 
> "~~~" squiggle, 122 occurrences of the word "failure", 6947 occurrences of 
> "fail", and 35,503 occurrences of the word "error." The bottom of the file 
> states "7988 warnings generated." Indeed, there are 1077 occurrences of the 
> line "warnings generated" in the build.
> It is not realistic for a human to plow through this stuff looking for the 
> one obscure pattern that indicates and actual problem.
> This build is unusually large and verbose for an open source project.
> Some improvements:
> * Separate out normal "narration" (echoing of shell commands) from actual 
> error output.
> * Fix the code to eliminate warnings, or turn off the warnings.
> * Turn off the extra checks which we just ignore.
> * Create a script that will grep through the file looking for the actual 
> failures, ignoring the "expected" errors and failures, identifying the real 
> ones.
> It also appears that the scripts build Javadoc (can't tell for what.) Impala 
> is famous for its highly unorthodox use of Javadoc comments; the generate 
> Javadoc will be gibberish. Either fix the comments to be Java-doc compliant, 
> or stop building Javadoc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org

Reply via email to