[
https://issues.apache.org/jira/browse/IMPALA-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150636#comment-17150636
]
Daniel Becker commented on IMPALA-7923:
---------------------------------------
TPCH scale factor 2, single node performance, master vs. packed decimals:
Report Generated on 2020-07-02
Run Description: "6c8a3dfc339e43a8992af2ff3429ba5940a061ec vs
513c19bc0a750960b97f0d4cd14a9bdc8bbd2860"
Cluster Name: UNKNOWN
Lab Run Info: UNKNOWN
Impala Version: impalad version 4.0.0-SNAPSHOT RELEASE ()
Baseline Impala Version: impalad version 4.0.0-SNAPSHOT RELEASE (2020-07-01)
+----------+-----------------------+---------+------------+------------+----------------+
| Workload | File Format | Avg (s) | Delta(Avg) | GeoMean(s) |
Delta(GeoMean) |
+----------+-----------------------+---------+------------+------------+----------------+
| TPCH(2) | parquet / none / none | 0.94 | +0.12% | 0.82 | +0.13%
|
+----------+-----------------------+---------+------------+------------+----------------+
+----------+----------+-----------------------+--------+-------------+------------+-----------+----------------+-------+----------------+---------+-------+
| Workload | Query | File Format | Avg(s) | Base Avg(s) |
Delta(Avg) | StdDev(%) | Base StdDev(%) | Iters | Median Diff(%) | MW Zval |
Tval |
+----------+----------+-----------------------+--------+-------------+------------+-----------+----------------+-------+----------------+---------+-------+
| TPCH(2) | TPCH-Q9 | parquet / none / none | 1.61 | 1.59 | +1.60%
| 1.24% | 2.13% | 30 | +2.63% | 2.64 | 3.56 |
| TPCH(2) | TPCH-Q15 | parquet / none / none | 0.49 | 0.48 | +1.25%
| 8.18% | 8.18% | 30 | +0.47% | 0.66 | 0.59 |
| TPCH(2) | TPCH-Q22 | parquet / none / none | 0.47 | 0.47 | +1.59%
| 4.31% | 2.02% | 30 | +0.12% | 1.49 | 1.81 |
| TPCH(2) | TPCH-Q20 | parquet / none / none | 0.69 | 0.69 | +1.16%
| 4.24% | 3.48% | 30 | +0.04% | 0.30 | 1.15 |
| TPCH(2) | TPCH-Q4 | parquet / none / none | 0.45 | 0.44 | +1.14%
| 6.01% | 5.77% | 30 | +0.04% | 0.29 | 0.74 |
| TPCH(2) | TPCH-Q13 | parquet / none / none | 1.41 | 1.40 | +0.26%
| 2.12% | 2.16% | 30 | -0.06% | -0.89 | 0.47 |
| TPCH(2) | TPCH-Q16 | parquet / none / none | 0.63 | 0.63 | +0.25%
| 3.67% | 3.00% | 30 | -0.06% | -0.24 | 0.28 |
| TPCH(2) | TPCH-Q8 | parquet / none / none | 1.29 | 1.29 | +0.21%
| 2.02% | 2.04% | 30 | -0.02% | -0.32 | 0.40 |
| TPCH(2) | TPCH-Q11 | parquet / none / none | 0.49 | 0.49 | +0.03%
| 5.93% | 5.66% | 30 | +0.08% | 0.32 | 0.02 |
| TPCH(2) | TPCH-Q5 | parquet / none / none | 1.22 | 1.22 | +0.10%
| 0.76% | 0.25% | 30 | -0.01% | -0.27 | 0.69 |
| TPCH(2) | TPCH-Q18 | parquet / none / none | 1.17 | 1.17 | +0.07%
| 2.69% | 2.58% | 30 | +0.02% | 0.40 | 0.10 |
| TPCH(2) | TPCH-Q10 | parquet / none / none | 0.80 | 0.80 | -0.04%
| 4.02% | 4.48% | 30 | -0.02% | -0.13 | -0.03 |
| TPCH(2) | TPCH-Q7 | parquet / none / none | 1.33 | 1.33 | -0.12%
| 1.25% | 1.45% | 30 | +0.00% | 0.09 | -0.34 |
| TPCH(2) | TPCH-Q3 | parquet / none / none | 0.84 | 0.84 | -0.10%
| 3.12% | 3.18% | 30 | -0.03% | -0.58 | -0.12 |
| TPCH(2) | TPCH-Q19 | parquet / none / none | 1.79 | 1.80 | -0.29%
| 1.29% | 1.35% | 30 | -0.05% | -0.85 | -0.84 |
| TPCH(2) | TPCH-Q21 | parquet / none / none | 2.19 | 2.20 | -0.31%
| 1.36% | 1.20% | 30 | -0.04% | -0.85 | -0.95 |
| TPCH(2) | TPCH-Q14 | parquet / none / none | 0.60 | 0.60 | -0.56%
| 3.96% | 3.57% | 30 | -0.01% | -0.10 | -0.58 |
| TPCH(2) | TPCH-Q2 | parquet / none / none | 0.67 | 0.68 | -0.44%
| 4.42% | 2.83% | 30 | -0.15% | -1.13 | -0.47 |
| TPCH(2) | TPCH-Q17 | parquet / none / none | 0.65 | 0.66 | -0.57%
| 5.99% | 4.94% | 30 | -0.05% | -0.40 | -0.40 |
| TPCH(2) | TPCH-Q1 | parquet / none / none | 0.99 | 0.99 | -0.73%
| 2.49% | 2.99% | 30 | +0.05% | 0.40 | -1.03 |
| TPCH(2) | TPCH-Q6 | parquet / none / none | 0.31 | 0.32 | -0.64%
| 5.84% | 6.34% | 30 | -0.07% | -0.97 | -0.41 |
| TPCH(2) | TPCH-Q12 | parquet / none / none | 0.53 | 0.53 | -0.74%
| 4.51% | 4.73% | 30 | -0.14% | -0.75 | -0.63 |
+----------+----------+-----------------------+--------+-------------+------------+-----------+----------------+-------+----------------+---------+-------+
> DecimalValue should be marked as packed
> ---------------------------------------
>
> Key: IMPALA-7923
> URL: https://issues.apache.org/jira/browse/IMPALA-7923
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Affects Versions: Impala 3.1.0
> Reporter: Tim Armstrong
> Assignee: Daniel Becker
> Priority: Major
>
> IMPALA-7473 was a symptom of a more general problem that DecimalValue is not
> guaranteed to be aligned by the Impala runtime, but the class is not marked
> as packed and, under some circumstances, GCC will emit code for aligned loads
> to value_ when value_ is an int128.
> Testing helps confirm that the compiler does not emit the problematic loads
> in practice, but it would be better to mark the struct as packed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
