[
https://issues.apache.org/jira/browse/IMPALA-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152628#comment-17152628
]
Daniel Becker commented on IMPALA-7923:
---------------------------------------
With TPCH scale factor 15:
Report Generated on 2020-07-07
Run Description: "6c8a3dfc339e43a8992af2ff3429ba5940a061ec vs
513c19bc0a750960b97f0d4cd14a9bdc8bbd2860"
Cluster Name: UNKNOWN
Lab Run Info: UNKNOWN
Impala Version: impalad version 4.0.0-SNAPSHOT RELEASE ()
Baseline Impala Version: impalad version 4.0.0-SNAPSHOT RELEASE (2020-07-01)
+----------+-----------------------+---------+------------+------------+----------------+
| Workload | File Format | Avg (s) | Delta(Avg) | GeoMean(s) |
Delta(GeoMean) |
+----------+-----------------------+---------+------------+------------+----------------+
| TPCH(15) | parquet / none / none | 3.58 | +0.67% | 2.65 | +0.62%
|
+----------+-----------------------+---------+------------+------------+----------------+
+----------+----------+-----------------------+--------+-------------+------------+-----------+----------------+-------+----------------+---------+-------+
| Workload | Query | File Format | Avg(s) | Base Avg(s) |
Delta(Avg) | StdDev(%) | Base StdDev(%) | Iters | Median Diff(%) | MW Zval |
Tval |
+----------+----------+-----------------------+--------+-------------+------------+-----------+----------------+-------+----------------+---------+-------+
| TPCH(15) | TPCH-Q22 | parquet / none / none | 2.07 | 1.91 | R +8.20%
| 1.18% | 1.70% | 30 | R +7.32% | 6.54 | 21.08 |
| TPCH(15) | TPCH-Q20 | parquet / none / none | 1.79 | 1.73 | +3.22%
| 3.92% | 2.85% | 30 | +2.88% | 3.20 | 3.56 |
| TPCH(15) | TPCH-Q3 | parquet / none / none | 2.96 | 2.84 | +4.25%
| 9.02% | 1.73% | 30 | +0.67% | 1.07 | 2.43 |
| TPCH(15) | TPCH-Q5 | parquet / none / none | 2.57 | 2.51 | +2.47%
| 2.64% | 2.77% | 30 | +2.05% | 3.13 | 3.49 |
| TPCH(15) | TPCH-Q11 | parquet / none / none | 0.90 | 0.88 | +2.64%
| 4.44% | 4.17% | 30 | +1.29% | 1.98 | 2.34 |
| TPCH(15) | TPCH-Q9 | parquet / none / none | 8.41 | 8.25 | +1.89%
| 2.00% | 2.12% | 30 | +1.82% | 3.55 | 3.52 |
| TPCH(15) | TPCH-Q13 | parquet / none / none | 6.52 | 6.42 | +1.57%
| 2.23% | 2.18% | 30 | +1.54% | 2.62 | 2.73 |
| TPCH(15) | TPCH-Q8 | parquet / none / none | 3.26 | 3.21 | +1.57%
| 4.50% | 3.60% | 30 | +1.48% | 1.21 | 1.47 |
| TPCH(15) | TPCH-Q1 | parquet / none / none | 5.67 | 5.59 | +1.52%
| 2.55% | 1.96% | 30 | +0.96% | 2.29 | 2.56 |
| TPCH(15) | TPCH-Q21 | parquet / none / none | 14.26 | 14.13 | +0.89%
| 1.35% | 1.56% | 30 | +1.07% | 2.81 | 2.37 |
| TPCH(15) | TPCH-Q16 | parquet / none / none | 1.64 | 1.62 | +1.16%
| 3.56% | 2.48% | 30 | +0.05% | 0.54 | 1.46 |
| TPCH(15) | TPCH-Q12 | parquet / none / none | 1.59 | 1.58 | +0.59%
| 3.84% | 4.12% | 30 | +0.06% | 0.26 | 0.58 |
| TPCH(15) | TPCH-Q7 | parquet / none / none | 2.75 | 2.74 | +0.40%
| 3.55% | 2.36% | 30 | +0.03% | 0.18 | 0.51 |
| TPCH(15) | TPCH-Q14 | parquet / none / none | 1.74 | 1.74 | +0.01%
| 3.11% | 2.69% | 30 | -0.02% | -0.24 | 0.01 |
| TPCH(15) | TPCH-Q19 | parquet / none / none | 2.79 | 2.79 | -0.12%
| 3.13% | 3.16% | 30 | -0.10% | -0.32 | -0.15 |
| TPCH(15) | TPCH-Q15 | parquet / none / none | 2.16 | 2.16 | -0.20%
| 3.14% | 3.33% | 30 | -0.05% | -0.26 | -0.24 |
| TPCH(15) | TPCH-Q4 | parquet / none / none | 1.37 | 1.38 | -0.75%
| 3.65% | 4.23% | 30 | -0.09% | -0.77 | -0.73 |
| TPCH(15) | TPCH-Q6 | parquet / none / none | 0.78 | 0.79 | -1.60%
| 3.62% | 4.25% | 30 | -0.15% | -2.45 | -1.58 |
| TPCH(15) | TPCH-Q18 | parquet / none / none | 9.04 | 9.20 | -1.78%
| 3.68% | 5.20% | 30 | -1.17% | -1.75 | -1.54 |
| TPCH(15) | TPCH-Q10 | parquet / none / none | 2.85 | 2.94 | -2.88%
| 2.94% | 2.69% | 30 | -3.50% | -3.69 | -4.02 |
| TPCH(15) | TPCH-Q2 | parquet / none / none | 1.02 | 1.05 | -2.87%
| 4.12% | 4.67% | 30 | -4.11% | -2.62 | -2.55 |
| TPCH(15) | TPCH-Q17 | parquet / none / none | 2.62 | 2.77 | I -5.27%
| 6.50% | 6.82% | 30 | I -4.68% | -2.95 | -3.14 |
+----------+----------+-----------------------+--------+-------------+------------+-----------+----------------+-------+----------------+---------+-------+
(R) Regression: TPCH(15) TPCH-Q22 [parquet / none / none] (1.91s -> 2.07s
[+8.20%])
+---------------------+------------+----------+----------+------------+-----------+----------+----------+------------+--------+-------+--------+-----------+
| Operator | % of Query | Avg | Base Avg | Delta(Avg) |
StdDev(%) | Max | Base Max | Delta(Max) | #Hosts | #Inst | #Rows | Est
#Rows |
+---------------------+------------+----------+----------+------------+-----------+----------+----------+------------+--------+-------+--------+-----------+
| 05:HASH JOIN | 49.75% | 1.30s | 1.28s | +1.83% | 0.93%
| 1.34s | 1.31s | +2.81% | 1 | 1 | 95.92K | 225.00K |
| 11:EXCHANGE | 7.00% | 183.11ms | 179.94ms | +1.76% | 0.81%
| 185.31ms | 188.78ms | -1.84% | 1 | 1 | 22.50M | 22.50M |
| F00:EXCHANGE SENDER | 33.99% | 889.62ms | 856.03ms | +3.92% | 0.86%
| 902.79ms | 880.68ms | +2.51% | 1 | 1 | -1 | -1 |
+---------------------+------------+----------+----------+------------+-----------+----------+----------+------------+--------+-------+--------+-----------+
(I) Improvement: TPCH(15) TPCH-Q17 [parquet / none / none] (2.77s -> 2.62s
[-5.27%])
+---------------------+------------+----------+----------+------------+------------+----------+----------+------------+--------+-------+--------+-----------+
| Operator | % of Query | Avg | Base Avg | Delta(Avg) |
StdDev(%) | Max | Base Max | Delta(Max) | #Hosts | #Inst | #Rows | Est
#Rows |
+---------------------+------------+----------+----------+------------+------------+----------+----------+------------+--------+-------+--------+-----------+
| 00:SCAN HDFS | 28.63% | 1.09s | 1.14s | -4.52% | 5.61%
| 1.21s | 1.34s | -9.84% | 1 | 1 | 91.27K | 89.99M |
| 08:AGGREGATE | 13.28% | 503.26ms | 535.62ms | -6.04% | *
15.58% * | 675.74ms | 706.87ms | -4.40% | 1 | 1 | 1.90M | 2.98M
|
| F00:EXCHANGE SENDER | 4.35% | 164.81ms | 179.56ms | -8.21% | *
18.37% * | 225.54ms | 241.99ms | -6.80% | 1 | 1 | -1 | -1
|
| 03:AGGREGATE | 9.78% | 370.88ms | 436.50ms | -15.03% | *
18.46% * | 510.79ms | 629.31ms | -18.83% | 1 | 1 | 1.90M | 2.98M
|
| 02:SCAN HDFS | 40.81% | 1.55s | 1.59s | -2.63% | 2.23%
| 1.62s | 1.70s | -4.81% | 1 | 1 | 3.09M | 89.99M |
+---------------------+------------+----------+----------+------------+------------+----------+----------+------------+--------+-------+--------+-----------+
> DecimalValue should be marked as packed
> ---------------------------------------
>
> Key: IMPALA-7923
> URL: https://issues.apache.org/jira/browse/IMPALA-7923
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Affects Versions: Impala 3.1.0
> Reporter: Tim Armstrong
> Assignee: Daniel Becker
> Priority: Major
>
> IMPALA-7473 was a symptom of a more general problem that DecimalValue is not
> guaranteed to be aligned by the Impala runtime, but the class is not marked
> as packed and, under some circumstances, GCC will emit code for aligned loads
> to value_ when value_ is an int128.
> Testing helps confirm that the compiler does not emit the problematic loads
> in practice, but it would be better to mark the struct as packed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
