[
https://issues.apache.org/jira/browse/IMPALA-9930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17204378#comment-17204378
]
ASF subversion and git services commented on IMPALA-9930:
---------------------------------------------------------
Commit 28181cbe6c59cc2f3da2246fd907d6bc69a5f7d2 in impala's branch
refs/heads/master from Thomas Tauber-Marshall
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=28181cb ]
IMPALA-9930 (part 1): Initial refactor for admission control service
This patch contains the following refactors that are needed for the
admission control service, in order to make the main patch easier to
review:
- Adds a new class AdmissionControlClient which will be used to
abstract the logic for submitting queries to either a local or
remote admission controller out from ClientRequestState/Coordinator.
Currently only local submission is supported.
- SubmitForAdmission now takes a BackendId representing the
coordinator instead of assuming that the local impalad will be the
coordinator.
- The CRS_BEFORE_ADMISSION debug action is moved into
SubmitForAdmission() so that it will be executed on whichever daemon
is performing admission control rather than always on the
coordinator (needed for TestAdmissionController.test_cancellation).
- ShardedQueryMap is extended to allow keys to be either TUniqueId or
UniqueIdPB and Add(), Get(), and Delete() convenience functions are
added.
- Some utils related to seralizing Thrift objects into sidecars are
added.
Testing:
- Passed a run of existing core tests.
Change-Id: I7974a979cf05ed569f31e1ab20694e29fd3e4508
Reviewed-on: http://gerrit.cloudera.org:8080/16411
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Introduce new admission control rpc service
> -------------------------------------------
>
> Key: IMPALA-9930
> URL: https://issues.apache.org/jira/browse/IMPALA-9930
> Project: IMPALA
> Issue Type: Sub-task
> Components: Backend
> Affects Versions: Impala 4.0
> Reporter: Thomas Tauber-Marshall
> Assignee: Thomas Tauber-Marshall
> Priority: Major
>
> In order to support the eventual single admission controller, we'll need to
> create rpc definitions for the service.
> The rpcs that will need to be defined are outlined in the design doc:
> https://docs.google.com/document/d/1nLovzk4rwZLct2yl-eT7VMHFBP7LswcJp7RqiP59RAc/edit
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
