[
https://issues.apache.org/jira/browse/IMPALA-9930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248102#comment-17248102
]
ASF subversion and git services commented on IMPALA-9930:
---------------------------------------------------------
Commit a3da5c580ab2fe3b0e991744cf8b994f52e3fafd in impala's branch
refs/heads/master from Thomas Tauber-Marshall
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=a3da5c5 ]
IMPALA-10383: Fix data race on AdmissionController::queue_nodes_
IMPALA-9930 introduces a new data structure to AdmissionController:
'queue_nodes_'. The intention was that access to 'queue_nodes_' should
always be protected by 'queue_nodes_lock_', but this was not always
the case.
This patch fixes the issue by ensuring that 'queue_nodes_lock_' is
held everywhere that 'queue_nodes_' is used.
Testing:
- Ran TSAN and confirmed there is no longer a data race being
reported.
Change-Id: I05b70112300d3a886bdd5f02fda0bd7ca98df6cf
Reviewed-on: http://gerrit.cloudera.org:8080/16835
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Introduce new admission control rpc service
> -------------------------------------------
>
> Key: IMPALA-9930
> URL: https://issues.apache.org/jira/browse/IMPALA-9930
> Project: IMPALA
> Issue Type: Sub-task
> Components: Backend
> Affects Versions: Impala 4.0
> Reporter: Thomas Tauber-Marshall
> Assignee: Thomas Tauber-Marshall
> Priority: Major
> Fix For: Impala 4.0
>
>
> In order to support the eventual single admission controller, we'll need to
> create rpc definitions for the service.
> The rpcs that will need to be defined are outlined in the design doc:
> https://docs.google.com/document/d/1nLovzk4rwZLct2yl-eT7VMHFBP7LswcJp7RqiP59RAc/edit
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
