[
https://issues.apache.org/jira/browse/IMPALA-10960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427394#comment-17427394
]
Quanlong Huang commented on IMPALA-10960:
-----------------------------------------
Thanks for the reply! So it sounds like a feature for users to prevent
themselves writing bad comments for their queries.
Before going directly into coding, could you summarize this feature (e.g.
whether you want to expose those info in profile), and explain how you would
implement this feature? I'm not sure if the regex format is popular/easy
enough, or maybe something like customized query hints will be more easy to use.
> Add query option for sql comment rule
> -------------------------------------
>
> Key: IMPALA-10960
> URL: https://issues.apache.org/jira/browse/IMPALA-10960
> Project: IMPALA
> Issue Type: New Feature
> Components: Backend
> Affects Versions: Impala 4.0.0
> Reporter: carolinchen
> Assignee: carolinchen
> Priority: Minor
> Labels: features
> Original Estimate: 12h
> Remaining Estimate: 12h
>
> SQL comment can be used to describe the SQL statements. with comments
> containing information about the SQL statements, This may help in easily
> correlating slow performance with source code.
> For better to use sql comment, we can set the sql comment rule with regular
> expression
> eg: set
> sql_comment_rule=/\*\s*author:\S+\s*?project:\S+\s*?desc:\S+\s*?.+\*/.+?;
> this example means that if the SQL statement want be addmitted by impala,
> its sql comment must include auther. project and desc's infomation. then we
> can trace the sql‘s origin.
> there are two steps:
> # Set sql_comment_rule by own way, with set sql_comment_rule query option in
> regular expression
> # Check the query‘s legality based on the sql_comment_rule which we have
> set. if check succeed, SQL can be admitted to Coordinator. otherwise, will
> refuse the query.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
