[
https://issues.apache.org/jira/browse/IMPALA-10960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427424#comment-17427424
]
Manish Maheshwari commented on IMPALA-10960:
--------------------------------------------
A set would not show up in the subsequent queries and thus would not help in
looking at the profiles via Cloudera Manager, profile logs to check the author,
project etc. A hint / comment in the query itself would be more easily
identifiable in both the query profies and search vis CM.
Also a set would need to be run many times if the user wants to change the
"desc" for any reason. A comment/hint can be modified in the SQL and does not
set commands to run. BI tools also allow tweaking of SQL's over running set
commands.
> Add query option for sql comment rule
> -------------------------------------
>
> Key: IMPALA-10960
> URL: https://issues.apache.org/jira/browse/IMPALA-10960
> Project: IMPALA
> Issue Type: New Feature
> Components: Backend
> Affects Versions: Impala 4.0.0
> Reporter: carolinchen
> Assignee: carolinchen
> Priority: Minor
> Labels: features
> Original Estimate: 12h
> Remaining Estimate: 12h
>
> SQL comment can be used to describe the SQL statements. with comments
> containing information about the SQL statements, This may help in easily
> correlating slow performance with source code.
> For better to use sql comment, we can set the sql comment rule with regular
> expression
> eg: set
> sql_comment_rule=/\*\s*author:\S+\s*?project:\S+\s*?desc:\S+\s*?.+\*/.+?;
> this example means that if the SQL statement want be addmitted by impala,
> its sql comment must include auther. project and desc's infomation. then we
> can trace the sql‘s origin.
> there are two steps:
> # Set sql_comment_rule by own way, with set sql_comment_rule query option in
> regular expression
> # Check the query‘s legality based on the sql_comment_rule which we have
> set. if check succeed, SQL can be admitted to Coordinator. otherwise, will
> refuse the query.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
