[ 
https://issues.apache.org/jira/browse/IMPALA-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430034#comment-17430034
 ] 

ASF subversion and git services commented on IMPALA-2905:
---------------------------------------------------------

Commit 1e92c097d97dd4c688b8994e3ea63e8de80e35ec in impala's branch 
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=1e92c09 ]

IMPALA-10950: Update expr-benchmark.cc

With the introduction of PlanRootSink by IMPALA-2905, query planner has
moved the scalar expression's thrift definition from
'fragments[0].output_sink.output_exprs' to
'fragments[0].plan.nodes[0].union_node.const_expr_lists[0]' for a
constant query. This patch adjusts expr-benchmark.cc to generate the
ScalarExpr from the right thrift location and also modify the helper
class to ensure proper resource cleanup at the end of the benchmark. We
explicitly set ENABLE_EXPR_REWRITES=0 to prevent expression rewrite by
FoldConstantsRule.java.

The benchmark used to run without codegen. This patch modifies the
benchmark to run a benchmark suite both with and without codegen.

Testing:
- Run and verify that expr-benchmark does not crash.

Change-Id: I5b17434d85e32a58622bffb64a697b062a8bf43f
Reviewed-on: http://gerrit.cloudera.org:8080/17894
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>


> Use FragmentMgr to manage coordinator fragments
> -----------------------------------------------
>
>                 Key: IMPALA-2905
>                 URL: https://issues.apache.org/jira/browse/IMPALA-2905
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Distributed Exec
>    Affects Versions: Impala 2.5.0
>            Reporter: Henry Robinson
>            Assignee: Henry Robinson
>            Priority: Minor
>              Labels: query-lifecycle
>             Fix For: Impala 2.8.0
>
>
> Impala's {{FragmentMgr}} manages all fragments except for the one run by the 
> coordinator. We should remove the special-case code in {{Coordinator}} that 
> requires this once IMPALA-1599 is finished, as that will allow us to start 
> the coordinator fragment in parallel with the rest of the query.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to