[
https://issues.apache.org/jira/browse/IMPALA-10950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430033#comment-17430033
]
ASF subversion and git services commented on IMPALA-10950:
----------------------------------------------------------
Commit 1e92c097d97dd4c688b8994e3ea63e8de80e35ec in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=1e92c09 ]
IMPALA-10950: Update expr-benchmark.cc
With the introduction of PlanRootSink by IMPALA-2905, query planner has
moved the scalar expression's thrift definition from
'fragments[0].output_sink.output_exprs' to
'fragments[0].plan.nodes[0].union_node.const_expr_lists[0]' for a
constant query. This patch adjusts expr-benchmark.cc to generate the
ScalarExpr from the right thrift location and also modify the helper
class to ensure proper resource cleanup at the end of the benchmark. We
explicitly set ENABLE_EXPR_REWRITES=0 to prevent expression rewrite by
FoldConstantsRule.java.
The benchmark used to run without codegen. This patch modifies the
benchmark to run a benchmark suite both with and without codegen.
Testing:
- Run and verify that expr-benchmark does not crash.
Change-Id: I5b17434d85e32a58622bffb64a697b062a8bf43f
Reviewed-on: http://gerrit.cloudera.org:8080/17894
Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
> expr-benchmark.cc needs some update
> -----------------------------------
>
> Key: IMPALA-10950
> URL: https://issues.apache.org/jira/browse/IMPALA-10950
> Project: IMPALA
> Issue Type: Bug
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Minor
> Fix For: Impala 4.1.0
>
>
> expr-benchmark compiles, but crash when it is executed.
> This is because the scalar expression's thrift definition has moved from
> {code:java}
> query_request.plan_exec_info[0].fragments[0].output_sink.output_exprs{code}
> to
> {code:java}
> query_request.plan_exec_info[0].fragments[0].plan.nodes[0].union_node.const_expr_lists[0]{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
