[
https://issues.apache.org/jira/browse/IMPALA-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493367#comment-17493367
]
ASF subversion and git services commented on IMPALA-10931:
----------------------------------------------------------
Commit 92ce6fe48e75d7780efe9a275122554e59aac916 in impala's branch
refs/heads/master from wzhou-code
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=92ce6fe ]
IMPALA-10931 (part2): Fixed rebased Kudu source to compile
This patch applies various fixes to Impala and to the copied Kudu
source code in be/src/kudu/* to allow everything to compile and pass
Impala exhaustive tests.
Highlights of the changes made:
- Some flags that have a DEFINE in both Kudu and Impala are modified
to change one of the DEFINEs to a DECLARE.
- Fixed backend unit-test bloom-filter-test.cc due to the changes for
block bloom filter false positive rate correction in
kudu/util/block_bloom_filter.cc.
- Set initial values of Sockaddr variables as Sockaddr::Wildcard().
- The parameter type of kudu::RpcSidecar::FromFaststring() was changed,
need to change the caller code in Impala.
- openssl_util.h was moved from directory kudu/security to kudu/util.
need to change including path in Impala.
This patch was in part based on the patches that were applied the last
time we rebased the Kudu code in IMPALA-9335. All changes from those
commits that are still relevant were included here.
Went through all commits that have been applied to the be/src/kudu
directory since the last rebase and ensured that all relevant changes
from those are included here. These include patches for IMPALA-9182,
IMPALA-10779, IMPALA-9940 and commit d9a38c0bac (Limit short versions
of KUDU_* macros to Kudu source).
Testing:
- Passed core debug build, core ASAN build and exhaustive release
build.
Change-Id: Ia9919c06e60d132d997093abb7b14825847e07c7
Reviewed-on: http://gerrit.cloudera.org:8080/18155
Reviewed-by: Joe McDonnell <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Rebase source code under be/src/kudu
> ------------------------------------
>
> Key: IMPALA-10931
> URL: https://issues.apache.org/jira/browse/IMPALA-10931
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Reporter: Wenzhe Zhou
> Assignee: Wenzhe Zhou
> Priority: Major
> Fix For: Impala 4.1.0
>
>
> Impala pulls KRPC in by copying and pasting several directories from Kudu's
> source code (/rpc, /util, and /security). This code has not been updated in
> more than a year and half. There are various fixes and improvements that have
> been made on the Kudu side, like supporting TLS v1.3 in KRPC. It would be
> nice to pull in all these improvements.
> There are a few patches which we made on the copied source code in
> be/src/kudu. We need to make sure that all those patches are incorporated or
> maintained when rebase be/src/kudu.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
