[
https://issues.apache.org/jira/browse/IMPALA-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499839#comment-17499839
]
ASF subversion and git services commented on IMPALA-10931:
----------------------------------------------------------
Commit 719d3688950e9c22811ca2bb619b616f89679593 in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=719d368 ]
IMPALA-10049: Include RPC call_id in slow RPC logs
KRPC log slow RPC trace in the receiver side. The trace log has the
call_id info that matches with the sender. However, our slow RPC logging
in the sender side does not log this call_id. It is hard to associate
the slow RPC logs between sender and receiver.
With the recent KRPC rebase in IMPALA-10931, we can now log the call_id
on the sender side.
Testing:
I tested this with a low threshold and delays added (the same as we did
in IMPALA-9128):
start-impala-cluster.py \
--impalad_args=--impala_slow_rpc_threshold_ms=1 \
--impalad_args=--debug_actions=END_DATA_STREAM_DELAY:JITTER@[email protected]
The following is how the logs look like on the sender and receiver sides:
impalad_node1.INFO (sender):
I0217 10:29:36.278754 6606 krpc-data-stream-sender.cc:394] Slow TransmitData
RPC (request call id 414) to 127.0.0.1:27002
(fragment_instance_id=d8453c2785c38df4:3473e28b00000041): took 343.279ms.
Receiver time: 342.780ms Network time: 498.405us
impalad_node2.INFO (receiver):
I0217 10:29:36.278379 6775 rpcz_store.cc:269] Call
impala.DataStreamService.TransmitData from 127.0.0.1:39702 (request call id
414) took 342ms. Trace:
I0217 10:29:36.278479 6775 rpcz_store.cc:270] 0217 10:29:35.935586 (+ 0us)
impala-service-pool.cc:179] Inserting onto call queue
0217 10:29:36.277730 (+342144us) impala-service-pool.cc:278] Handling call
0217 10:29:36.277859 (+ 129us) krpc-data-stream-recvr.cc:397] Deserializing
batch
0217 10:29:36.278330 (+ 471us) krpc-data-stream-recvr.cc:424] Enqueuing
deserialized batch
0217 10:29:36.278369 (+ 39us) inbound_call.cc:171] Queueing success response
Metrics: {}
Change-Id: I7fb5746fa0be575745a8e168405d43115c425389
Reviewed-on: http://gerrit.cloudera.org:8080/18243
Reviewed-by: Wenzhe Zhou <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Rebase source code under be/src/kudu
> ------------------------------------
>
> Key: IMPALA-10931
> URL: https://issues.apache.org/jira/browse/IMPALA-10931
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Reporter: Wenzhe Zhou
> Assignee: Wenzhe Zhou
> Priority: Major
> Fix For: Impala 4.1.0
>
>
> Impala pulls KRPC in by copying and pasting several directories from Kudu's
> source code (/rpc, /util, and /security). This code has not been updated in
> more than a year and half. There are various fixes and improvements that have
> been made on the Kudu side, like supporting TLS v1.3 in KRPC. It would be
> nice to pull in all these improvements.
> There are a few patches which we made on the copied source code in
> be/src/kudu. We need to make sure that all those patches are incorporated or
> maintained when rebase be/src/kudu.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
