[
https://issues.apache.org/jira/browse/IMPALA-11249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523832#comment-17523832
]
Joe McDonnell commented on IMPALA-11249:
----------------------------------------
It's suspicious to have a add_test_dimensions() that doesn't call it's
superclass's add_test_dimensions() (or doesn't initialize ImpalaTestMatrix
itself). That should be discouraged, independent of whether it has anything to
do with this.
> Precommits are not running strict_hs2_protocol=True configurations for shell
> tests
> ----------------------------------------------------------------------------------
>
> Key: IMPALA-11249
> URL: https://issues.apache.org/jira/browse/IMPALA-11249
> Project: IMPALA
> Issue Type: Bug
> Components: Clients
> Affects Versions: Impala 4.1.0
> Reporter: Joe McDonnell
> Priority: Major
>
> When debugging a shell test failure, I noticed that the set of tests running
> in precommit is different from what happens when I run in my development
> environment. In precommit, none of the strict_hs2_protocol=True shell tests
> run. I can't figure out why it behaves that way from the code, given that we
> enable this test dimension:
> {noformat}
> def add_test_dimensions(cls):
> # Run with both beeswax and HS2 to ensure that behaviour is the same.
> cls.ImpalaTestMatrix.add_dimension(create_client_protocol_dimension())
>
> cls.ImpalaTestMatrix.add_dimension(create_client_protocol_strict_dimension())
> cls.ImpalaTestMatrix.add_constraint(lambda v:
> v.get_value('protocol') != 'beeswax' or not
> v.get_value('strict_hs2_protocol')){noformat}
> And create_client_protocol_strict_dimension() should produce both False and
> True:
> {noformat}
> def create_client_protocol_strict_dimension():
> # only support strict dimensions if the file system is HDFS, since that is
> # where the hive cluster is run.
> if IS_HDFS:
> return ImpalaTestDimension('strict_hs2_protocol', False, True)
> else:
> return create_client_protocol_no_strict_dimension(){noformat}
> When I run locally, those tests run (and there are some failures to fix).
> Example precommit job:
> https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/16296/testReport/shell.test_shell_interactive/TestImpalaShellInteractive/
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
