[
https://issues.apache.org/jira/browse/IMPALA-11258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526166#comment-17526166
]
Quanlong Huang commented on IMPALA-11258:
-----------------------------------------
Some test does have warnings that can be ignored, e.g.
{code:java}
---- QUERY
# Regression test for IMPALA-1508
select timestamp_col FROM alltypesagg
ORDER BY timestamp_col + INTERVAL bigint_col YEAR ASC limit 1
---- RESULTS
2010-01-01 00:01:00
---- TYPES
TIMESTAMP{code}
[https://github.com/apache/impala/blob/e8e637873c0527a60d1de0f63c3f268328a9c84c/testdata/workloads/functional-query/queries/QueryTest/exprs.test#L1936-L1937]
The query has lots of warnings:
{code:java}
WARNINGS: UDF WARNING: Add/sub year resulted in an out of range year: 10000
UDF WARNING: Cannot add interval 7990: Year is out of valid range: 1400..9999
UDF WARNING: Add/sub year resulted in an out of range year: 10010
UDF WARNING: Cannot add interval 8000: Year is out of valid range: 1400..9999
UDF WARNING: Add/sub year resulted in an out of range year: 10020
UDF WARNING: Cannot add interval 8010: Year is out of valid range: 1400..9999
UDF WARNING: Add/sub year resulted in an out of range year: 10030
UDF WARNING: Cannot add interval 8020: Year is out of valid range: 1400..9999
UDF WARNING: Add/sub year resulted in an out of range year: 10040
UDF WARNING: Cannot add interval 8030: Year is out of valid range: 1400..9999
UDF WARNING: Add/sub year resulted in an out of range year: 10050
... {code}
I think we just need to verify there are no memory leak warnings.
> Test cases should verify there are no errors/warnings
> -----------------------------------------------------
>
> Key: IMPALA-11258
> URL: https://issues.apache.org/jira/browse/IMPALA-11258
> Project: IMPALA
> Issue Type: Test
> Reporter: Quanlong Huang
> Assignee: Quanlong Huang
> Priority: Major
>
> During the review of [https://gerrit.cloudera.org/c/18413,] I see a test case
> that has warnings on memory leak still be able to pass. We currently just
> verify the expected error messages when there are ERRORS sections. We should
> verify that when no ERRORS section is provided, the test should have no
> warnings/errors.
> {code:python}
> if 'ERRORS' in test_section:
> expected_errors =
> split_section_lines(remove_comments(test_section['ERRORS']))
> actual_errors = apply_error_match_filter(exec_result.log.split('\n'),
> replace_filenames)
> try:
> verify_errors(expected_errors, actual_errors)
> except AssertionError:
> if update_section:
> test_section['ERRORS'] = join_section_lines(actual_errors)
> else:
> raise{code}
> [https://github.com/apache/impala/blob/1358700740dbeff799f6a6a95f95b1d9fe7281d2/tests/common/test_result_verifier.py#L373-L383]
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
