[
https://issues.apache.org/jira/browse/IMPALA-13512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896401#comment-17896401
]
ASF subversion and git services commented on IMPALA-13512:
----------------------------------------------------------
Commit 24581704d8820dc691a43d69629dce7fac848597 in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=24581704d ]
IMPALA-13512: Print .test file name if PlannerTest fail
This patch improve PlannerTest by printing the path to .test file that
is failed. It also skip printing VERBOSE plan if
PlannerTestOption.EXTENDED_EXPLAIN is specified, since EXTENDED level
already contains sufficient details including tuples, sizes, and
cardinality.
This patch also change target path to save the updated end-to-end test file
if --update_results parameter is set. For example:
Before:
$EE_TEST_LOGS_DIR/tpcds-decimal_v2-q98.test
After:
$EE_TEST_LOGS_DIR/impala_updated_results/tpcds/queries/tpcds-decimal_v2-q98.test
Also ensure that the updated test file ends with a newline.
Testing:
- Manualy run modified PlannerTest that will fail and set
EXTENDED_EXPLAIN test option. Verified that .test file name is
printed and VERBOSE plan is not printed.
- Manually run TestTpcdsDecimalV2Query with --update_results parameter
and confirm the updated test file path is correct.
Change-Id: I5e15af93d9016d78ac0575c433146c8513a11949
Reviewed-on: http://gerrit.cloudera.org:8080/22030
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Print .test file name if PlannerTest fail
> -----------------------------------------
>
> Key: IMPALA-13512
> URL: https://issues.apache.org/jira/browse/IMPALA-13512
> Project: IMPALA
> Issue Type: Improvement
> Components: Test
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Minor
> Fix For: Impala 4.5.0
>
>
> If PlannerTest fail, error message will show hint of which test case fail by
> printing the section and line number like this:
> {code:java}
> Error Message
> Section PLAN of query at line 239: {code}
> This can be improved by also printing the path to .test file that is failed
> like this:
> {code:java}
> Error Message
> Section PLAN of query at
> functional-planner/queries/PlannerTest/runtime-filter-cardinality-reduction.test:239:
> {code}
> PlannerTest should also skip printing VERBOSE plan if
> PlannerTestOption.EXTENDED_EXPLAIN is specified, since EXTENDED level already
> contains sufficient details including tuples, sizes, and cardinality.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
