[
https://issues.apache.org/jira/browse/IMPALA-13502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896399#comment-17896399
]
ASF subversion and git services commented on IMPALA-13502:
----------------------------------------------------------
Commit abd2c199629d6a0d2ec547a90d40c0ad341a4483 in impala's branch
refs/heads/master from Michael Smith
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=abd2c1996 ]
IMPALA-13502: Clean up around constructors
Makes 'name' a required parameter around CreateBinaryPhiNode,
CodegenNullPhiNode, and CodegenIsNullPhiNode to skip rare case where we
generate a name.
Uses raw pointers or const& rather than const shared_ptr& in some cases
to simplify API.
Removes unused TSaslServerTransport constructors.
Reuses CharMemTrackerAllocator and OutboundRowBatch in TupleFileWriter.
Change-Id: I4321888808a6b26f42664163e1d1fa137dbc7d14
Reviewed-on: http://gerrit.cloudera.org:8080/22010
Reviewed-by: Riza Suminto <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Constructor cleanup
> -------------------
>
> Key: IMPALA-13502
> URL: https://issues.apache.org/jira/browse/IMPALA-13502
> Project: IMPALA
> Issue Type: Task
> Components: Backend
> Reporter: Michael Smith
> Assignee: Michael Smith
> Priority: Minor
> Fix For: Impala 4.5.0
>
>
> Various cleanup ideas around constructors identified in IMPALA-12390.
> - Replace {{const shared_ptr<>&}} with row pointers to make the API simpler
> and more general.
> - LLVM CreateBinaryPhiNode, CodegenNullPhiNode, and CodegenIsNullPhiNode
> should all make {{name}} mandatory. Remove empty name handling from
> CreateBinaryPhiNode.
> - Several TSaslServerTransport constructors may be unused.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
