[
https://issues.apache.org/jira/browse/IMPALA-13668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916822#comment-17916822
]
ASF subversion and git services commented on IMPALA-13668:
----------------------------------------------------------
Commit 30050923320e5bbd2de0c17b3c48548b0c7a8080 in impala's branch
refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=300509233 ]
IMPALA-13668: Add default_test_protocol parameter to py.test
ImpalaTestSuite.client is always initialized as beeswax client. And many
tests use it directly rather than going through helper method such as
execute_query().
This patch add add default_test_protocol parameter to conftest.py. It
control whether to initialize ImpalaTestSuite.client equals to
'beeswax_client', 'hs2_client', or 'hs2_http_client'. This parameter is
still default to 'beeswax'.
This patch also adds helper method 'default_client_protocol_dimension',
'beeswax_client_protocol_dimension' and 'hs2_client_protocol_dimension'
for convenience and traceability.
Reduced occurrence where test method manually override
ImpalaTestSuite.client. They are replaced by combination of
ImpalaTestSuite.create_impala_clients and
ImpalaTestSuite.close_impala_clients.
Testing:
- Pass core tests.
Change-Id: I9165ea220b2c83ca36d6e68ef3b88b128310af23
Reviewed-on: http://gerrit.cloudera.org:8080/22336
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Add default_test_protocol parameter to conftest.py
> --------------------------------------------------
>
> Key: IMPALA-13668
> URL: https://issues.apache.org/jira/browse/IMPALA-13668
> Project: IMPALA
> Issue Type: Improvement
> Components: Test
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Major
>
> ImpalaTestSuite.client is always initialized as beeswax client. And many
> tests use it directly rather than going through helper method such as
> execute_query().
> https://github.com/apache/impala/blob/5f4321373a3404867e170f7381db04a843aa7310/tests/common/impala_test_suite.py#L354
> We should add default_test_protocol parameter to conftest.py so that we can
> change it to hs2 or hs2-http client. This will help us check which tests is
> already compatible with hs2 and which one still need adjustment.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
